First Flight #2: Puppy Raffle

Summary

enterRaffle function not following Checks,Effects,Interaction pattern

Vulnerability Details

Check for duplicates should occur before pushing new players into the array. it could loop through the newPlayers array
and check for duplicates first and it could revert before adding new players.
Checks -> Effects -> Interactions should be followed

Impact

players being added to the array and then having to roll back the changes if they are duplicate

Tools Used

VSCode

Recommendations

check for duplicates before adding to array, this is more efficient and follows the Checks -> Effects -> Interactions pattern