Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: high
Invalid

selectWinner should set the state

Summary

selectWinner should update raffle state

Vulnerability Details

when drawing the raffle, it should set to "drawing" state to prevent players from entering while the draw is being determined. Because the generation of random numbers using Chainlink VRF can take some time, we need to prevent new players from entering while this is being done.

Impact

new players entering while the draw is still being done will result in players losing their entry fee

Tools Used

VSCode

Recommendations

use a raffle state and set to drawing while winner is being selected

Updates

Lead Judging Commences

Hamiltonite Lead Judge about 2 years ago
Submission Judgement Published
Invalidated
Reason: User experience and design improvement
Assigned finding tags:

weak-randomness

Root cause: bad RNG Impact: manipulate winner

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!