First Flight #2: Puppy Raffle

Summary

Looping an array with no upper limit would result in high gas consumption and possible transaction failure. Also, if the gas limit for a block is exceeded, function invocations will always fail.

Vulnerability Details

The players array has no restrictions on additions and can be a huge array. Therefore, functions that include looping through it may not be able to be invoked.

Impact

Key features will not work.

Tools Used

Manual

Recommendations

Set an upper limit on the number of arrays.