Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Lack of Event Emission for selectWinner function

Summary

The selectWinner function lacks event emission, leading to a significant transparency and traceability issue for users and external applications interacting with the contract. This omission hampers the ability to verify the raffle's results.

Vulnerability Details

  1. Lack of Transparency:
    Without Events, it becomes challenging for users, interfaces, and external applications to track when a winner has been selected and the prize has been sent.

  2. Difficulty in Verification:
    Events provide an efficient way to verify actions on-chain.The absence of events means that verifying the selection of a winner and the proper distribution of prizes becomes more complex and less straightforward.

Impact

Verification challenges

Tools Used

Foundry, manual

Recommendations

Emit Events for Significant Actions: Update the selectWinner function to emit events when significant actions occur, such as when a winner is selected, when the prize is sent, and when the game state is reset.

Updates

Lead Judging Commences

Hamiltonite Lead Judge about 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

events are missing or not detailed enough

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!