First Flight #2: Puppy Raffle

Summary

Function getActivePlayerIndex will return wrong value if parameter is either address(0) or address that is not in the players array.

Vulnerability Details

If the parameter player is address(0) or address that is not in the players array, the function will return 0. This will be invalid because the player at index 0 is different.

Impact

Wrong return value.

Tools Used

Manual Review

Recommendations

I think the best solution for this will be to return index that is outside of the array