First Flight #2: Puppy Raffle

Summary

Missing input user validation on changeFeeAddress()

Vulnerability Details

newFeeAddress is not check at the beginning of the function. If its value is address(0), the collected raffle fees will be lost. Gas will be wasted unnecessarily if the new fee address is the same as the current fee address.

Impact

This can lead to permanent lost of ether and gas wasting.

Tools Used

Manual review

Recommendations

Add a check for newFeeAddress to be different from the address(0) and different from the feeAddress (the current fees address).