First Flight #2: Puppy Raffle

[Low] Arithmetic operation overflow/underflow may lead to unintended behaviour.

Prior to Solidity 0.8, Arithmetic overflow/underflow can occur and lead to unintended behavior.

github: [link] (https://github.com/Cyfrin/2023-10-Puppy-Raffle/blob/e01ef1124677fb78249602a171b994e1f48a1298/src/PuppyRaffle.sol#L131-L133)

Recommendations

implement OpenZeppelin's SafeMath.

[Low] State Address Changes Should Be a Two-Step Procedure

Direct state address changes in a function can be risky, as they don't allow for a verification step before the change is made. It's safer to implement a two-step process where the new address is first proposed, then later confirmed, allowing for more control and the chance to catch errors or malicious activity.

github: link

[Low] Unsafe downcasting may lead to unexpected behaviour.

Downcasting from a larger integer type to a smaller one without checks can lead to unexpected behavior if the value of the larger integer is outside the range of the smaller one. This could lead to unexpected results due to overflow.

github: link

Recommendation

Implement OpenZeppelin's SafeCast OR check for overflow when downcasting.

[QA] Remove unused internal function for code clarity.

The following internal function is not found to be used anywhere. This can lead to confusion and clutter, making the code harder to understand and maintain.

github: link