Submission Details
Severity:
_isActivePlayer is unused
Summary
The function _isActivePlayer has internal visibility but is never used. This could be conceivably used for a front end to allow players to check if they're active, but this is impossible with current visibility.
Vulnerability Details
function _isActivePlayer() internal view returns (bool) {
for (uint256 i = 0; i < players.length; i++) {
if (players[i] == msg.sender) {
return true;
}
}
return false;
}
The above function is not called by any other contract functions, nor is it accessible externally for a front end.
Impact
Tools Used
Foundry
Manual Review
Recommendations
Make the function public.
function _isActivePlayer() public view returns (bool) {
for (uint256 i = 0; i < players.length; i++) {
if (players[i] == msg.sender) {
return true;
}
}
return false;
}
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.