Submission Details
Severity:
`_isActivePlayer()` internal function is dead function
Summary
Below function is implemented to check if the msg.sender is an active player according to the inline comments.
/// @notice this function will return true if the msg.sender is an active player
function _isActivePlayer() internal view returns (bool) {
for (uint256 i = 0; i < players.length; i++) {
if (players[i] == msg.sender) {
return true;
}
}
return false;
}
Vulnerability Details
Since the function is an internal it can't be called externally. there is also no other function calls the _isActivePlayer() function.
PuppyRaffle._isActivePlayer() is never used and should be removed
Impact
There is no significant impact other than code hygiene.
Tools Used
Manual code review
Recommendations
It's recommended to remove unused code from the codebase.
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.