Submission Details
Severity:
Function 'getActivePlayerIndex' returns ambiguous results
Summary
Ambiguous result
Vulnerability Details
Function 'getActivePlayerIndex' returns 0 for both zeroth player and for non-existing player.
Impact
If the function is called with the address that is stored at index 0 the result would be zero - the same as if the function is called with any address that is not stored in the 'players' array.
Tools Used
Manual review
Recommendations
Return -1 for non-existing player.
Updates
Lead Judging Commences
Hamiltonite almost 2 years ago
Submission Judgement Published Assigned finding tags:
getActivePlayerIndex can say a player is both entered at slot 0 and inactive
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.