Misleading require statement in selectWinner()
Summary
Misleading require statement in selectWinner()
Vulnerability Details
The check 'require(players.length >= 4, "PuppyRaffle: Need at least 4 players")' does not take into account that the 'players' array could be filled with address(0) values only.
Impact
The function logic could proceed assuming there are active players while there are none.
Tools Used
Manual review
Recommendations
The actual culprit is the 'refund' function. It simply must be removed. However if the issue is to be fixed locally, it must be checked that there are at least 4 non-zero addresses.
Lead Judging Commences
refund-doesnt-reduce-players-array-size-causing-protocol-to-freeze
zero address can win the raffle
Funds are locked to no one. If someone gets the refund issue, they also got this issue. IMPACT: High Likelihood: High
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.