Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

getActivePlayer index returns erroneous value

Summary

getActivePlayer index returns 0 if address is not present, but index 0 is a valid index value for the first address to enter the raffle.

Vulnerability Details

A user can be confused into thinking they are in the contest and continue to request a refund, spending gas, because of index 0.

Impact

Low

Tools Used

Manual review

Recommendations

Revert if user is not found instead of returning a valid value.

Updates

Lead Judging Commences

Hamiltonite Lead Judge about 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

getActivePlayerIndex can say a player is both entered at slot 0 and inactive

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!