Submission Details
Severity:
Ownable constructor initialization is missing
Summary
PuppyRaffle.sol constructor does not contain the Ownable constructor initialization
Vulnerability Details
PuppyRaffle.sol inherits from OZ Ownable contract as follows:
contract PuppyRaffle is ERC721, Ownable {
but in the constructor we see :
constructor(uint256 _entranceFee, address _feeAddress, uint256 _raffleDuration) ERC721("Puppy Raffle", "PR") {
the Ownable(address owner) is missing
Impact
This could introduce problems in compilation and - in the future- integration.
Tools Used
Mannual review
Recommendations
Add Ownable(address owner) to PuppyRaffle.sol's constructor like that:
- constructor(uint256 _entranceFee, address _feeAddress, uint256 _raffleDuration) ERC721("Puppy Raffle", "PR") {
+ constructor(uint256 _entranceFee, address _feeAddress, uint256 _raffleDuration) ERC721("Puppy Raffle", "PR") Ownable( address owner) {
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.