First Flight #2: Puppy Raffle

Summary

The players array can grow too large and thus become unusable.

Vulnerability Details

If the players array grows too large, new users will be prevented from participating as their call will run out of gas when checking for duplicates. This means that a malicious user can fill the array with their addresses and there will be a very high likelihood that they will end up the winner. If chances are greater than 50% and the economics make sense, they can prevent others from entering and thus gaming the raffle each time.

Impact

Medium

Tools Used

Foundry

Recommendations

Use mappings and uints to keep track of player status and participation rates.