First Flight #2: Puppy Raffle

Summary

The contract sends Ether to an external address without a re-entrancy guard.

Vulnerability Details

Though the contract does not directly update its state before making the external call to transfer Ether, it's a good practice to use a re-entrancy guard to prevent any future issues that could make it vulnerable to re-entrancy attacks.

The most common one is Openzeppelin reentrancy guard.

Impact

potentially allow for re-entrancy attacks if the contract state is modified in the future before the external call.

Tools Used

Manual code review

Recommendations

Implement a re-entrancy guard using OpenZeppelin's ReentrancyGuard