First Flight #2: Puppy Raffle

Summary

There are some unbounded loops that can lead to a Denial of Service (DoS) attack.

Vulnerability Details

The the enterRaffle() function iterates through all players to check if any player is already registered (duplicate address). The function performs certain checks to add the player's address to the players array. However, with all these operations taking place, the loop and gas consumption may cause a contract revert due to exceeding the block's gas limit.

Impact

Players cannot enter the raffle, and the primary service of this contract will be denied.

Tools Used

Manual Review

Recommendations

To avoid this issue, limit the size of the players array.