Submission Details
Severity:
getActivePlayerIndex returns valid index if player not found
Summary
The function getActivePlayerIndex loops through array and returns 0 if players has not been found. This is ambiguous since 0 is a valid index for array in Solidity.
Vulnerability Details
Function returns 0, which is a valid array index.
Impact
Misleading return value
Recommendations
Either:
Return -1 as int256
Return uint256 max value and make it explicit to the consumer of the contract
Revert with error
Updates
Lead Judging Commences
Hamiltonite almost 2 years ago
Submission Judgement Published Assigned finding tags:
getActivePlayerIndex can say a player is both entered at slot 0 and inactive
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.