`selectWinner` can be manipulated
Summary
selectWinner can be manipulated
Vulnerability Details
enterRaffle allows players to join the raffle even after the raffle has ended. selectWinner calculates the winner using the length of players array.
A malicious player can enroll more account in the raffle after the raffle has ended hence changing the length of the players array and hence changing the winner to someone else or worse to themselves!
Impact
A malicious player can change the winner by enrolling more accounts after the raffle has ended.
Tools Used
Manual
Recommendations
Use VRFs to generate random numbers can choose winners.
Lead Judging Commences
weak-randomness
Root cause: bad RNG Impact: manipulate winner
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.