Submission Details
Severity:
Unsafe downcast of uint256 to uint64 for fee accumulation
[M-02] Unsafe cast of PuppyRaffle::fee loses fees
Description:
When accumulating fees, due to the fact that totalFees is uint64, both arguments should be uint64. Thats why in the code there is a downcast from uint256 to unit64, which is the reason the contract loses fees.
Impact:
Makes it less incentivising for the contract owner/owner of fee address.
Tools used:
foundry, manual
Proof of Concept:
function testDowncastOfUint256toUint64() public pure {
// possible amount of fees generated at for example round 10 of winner selection
// because the entrance fee can be large amount, this amount is possible
uint256 generatedFromSelectedWinnerAtRoundN = 2**64 + 1;
assert(uint64(generatedFromSelectedWinnerAtRoundN) < generatedFromSelectedWinnerAtRoundN);
}
Recommended Mitigation:
Make totalFees type uint256 so you dont need to downcast to uint64
Updates
Lead Judging Commences
Hamiltonite almost 2 years ago
Submission Judgement Published Assigned finding tags:
unsafe cast of fee to uint64
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.