Submission Details
Severity:
It is possible to reopen a deposit after being closed
Summary
Close vault should be one way action, which should permanently stop the vault. However, due to lack of checks inside emergencyPause the vault could be reopened.
Vulnerability Details
The vault could be reopened using following actions:
{The vault is being closed} => emergencyClose() (Will set vault's state from "Closed" to "Paused") => emergencyResume() (Will change state from "Paused" to "Open")
Impact
Business logic error
Tools Used
Manual Review
Recommendations
On emergencyPause() check wether the whether the vault is closed:
function emergencyPause(
GMXTypes.Store storage self
) external {
if(self.status == GMXTypes.Status.Closed) revert TheVaultIsClosed(self);
Updates
Lead Judging Commences
hans almost 2 years ago
Submission Judgement Published Assigned finding tags:
Vault can be opened again after close
Prize pool breakdown
Total prize
35,000 USDC
nSLOC
2,28915 USDC / LOC
33,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.