Steadefi
Steadefi
DeFiHardhatFoundryOracle
35,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Multiple address `mapping`s can be combined into a single `mapping` of an address to a struct, where appropriate

larsson

Summary

See instances below:

contracts/oracles/ChainlinkARBOracle.sol
​
37: mapping(address => address) public feeds;
​
39: mapping(address => uint256) public maxDelays;
​
41: mapping(address => uint256) public maxDeviations;

https://github.com/Cyfrin/2023-10-SteadeFi/blob/main/contracts/oracles/ChainlinkARBOracle.sol#L37

https://github.com/Cyfrin/2023-10-SteadeFi/blob/main/contracts/oracles/ChainlinkARBOracle.sol#L39

https://github.com/Cyfrin/2023-10-SteadeFi/blob/main/contracts/oracles/ChainlinkARBOracle.sol#L41

contracts/strategy/gmx/GMXVault.sol
​
41: mapping(address => bool) public keepers;
​
43: mapping(address => bool) public tokens;

https://github.com/Cyfrin/2023-10-SteadeFi/blob/main/contracts/strategy/gmx/GMXVault.sol#L41

https://github.com/Cyfrin/2023-10-SteadeFi/blob/main/contracts/strategy/gmx/GMXVault.sol#L43

Updates

Lead Judging Commences

hans Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.