Summary

CEI pattern has been violated which would in turn increases the risks of reentrancy. In the current function implementation, there is a potential risk of reentrancy.

Vulnerability Details

There is an external call in the function processDepositCancellation() this function is called by a user to cancel a deposit. since it updates state after the function has completed there is potential reentrancy risk.

Impact

A malicious user will deposit funds and cancels the deposit, just right after the transaction has been cancelled and the funds transferred to him but before the status is set to open this could lead to reentrancy risks

Tools Used

manual analysis

Recommendations

ensure the function follows CEI to ensure all state is modified before external calls and add a Reentrancy Guard