Steadefi

Summary:

The contract contains checks to determine if certain unsigned integer values are less than zero. Given the nature of unsigned integers (they can never be negative), these checks are redundant and can be safely removed to simplify the code and save on gas costs.

Vulnerability Details:

In the following functions:

1. addTokenMaxDelay

2. addTokenMaxDeviation

The contract checks if the values maxDelay and maxDeviation are less than zero using the conditions:

and

These checks are unnecessary since maxDelay and maxDeviation are of the uint256 type, which can never be negative.

Impact:

This does not pose a direct security risk but introduces unnecessary complexity to the code. It may confuse developers or auditors who later review the contract, thinking there might be some special reason for the check.

Tools Used:

Manual Review

Recommendations:

1. Removal of Redundant Checks: The checks for maxDelay and maxDeviation being less than zero can be safely removed from the contract.

   Before:

   if (maxDelay < 0) revert Errors.TokenPriceFeedMaxDelayMustBeGreaterOrEqualToZero(); and

   if (maxDeviation < 0) revert Errors.TokenPriceFeedMaxDeviationMustBeGreaterOrEqualToZero();

   After:

   // No need for the check, simply proceed with the function's logic.