Submission Details
Severity:
Setter functions for core GMX contracts
Summary
GMX docs state that their ExchangeRouter and GMXOracle contracts will change as new logic is added. Therefore setter functions should be added to GMXVault.sol to be able to update the state variables storing those addressed when the need arises.
Vulnerability Details
From the GMX docs:
If using contracts such as the ExchangeRouter, Oracle or Reader do note that their addresses will change as new logic is added
Impact
Not being able to use the ExchangeRouter and GMXOracle contracts the protocol would effectively be unusable given their importance.
Tools Used
Manual Review
Recommendations
Create setter functions in GMXVault.sol as below:
function updateExchangeRouter(address exchangeRouter) external onlyOwner {
_store.exchangeRouter = exchangeRouter;
emit ExchangeRouterUpdated(exchangeRouter);
}
function updateGMXOracle(address gmxOracle) external onlyOwner {
_store.gmxOracle = gmxOracle;
emit GMXOracleUpdated(gmxOracle);
}
Prize pool breakdown
Total prize
35,000 USDC
nSLOC
2,28915 USDC / LOC
33,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.