Submission Details
Severity:
Not checked stale ChainLink price
Summary
ChainlinkOracle#_badChainlinkResponse is not checked stale ChainLink price.
Vulnerability Details
function _badChainlinkResponse(ChainlinkResponse memory response) internal view returns (bool) {
// Check for response call reverted
if (!response.success) { return true; }
// Check for an invalid roundId that is 0
if (response.roundId == 0) { return true; }
// Check for an invalid timeStamp that is 0, or in the future
if (response.timestamp == 0 || response.timestamp > block.timestamp) { return true; }
// Check for non-positive price
if (response.answer == 0) { return true; }
return false;
}
as we can see, ths function not checked the returned ChainLink price is stale or not.
Impact
Protocol may use a stale ChainLink price.
Tools Used
vscode, Manual Review
Recommendations
Change if (response.timestamp == 0 || response.timestamp > block.timestamp) { return true; } to if (response.timestamp == 0 || response.timestamp > block.timestamp || max_delay_time < block.timestamp - response.timestamp) { return true; }
Prize pool breakdown
Total prize
35,000 USDC
nSLOC
2,28915 USDC / LOC
33,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.