Submission Details
Severity:
`ChainlinkARBOracle::addTokenMaxDeviation(),addTokenMaxDelay(),addTokenPriceFeed()` wastes gas
Summary
We can combine the repeated checks in ChainlinkARBOracle::addTokenMaxDeviation(),addTokenMaxDelay(), ChainlinkARBOracle::addTokenPriceFeed() and also for ChainlinkARBOracle::getMarketTokenInfo into a single check.
Vulnerability Details
In ChainlinkARBOracle::addTokenMaxDeviation()
if (token == address(0)) revert Errors.ZeroAddressNotAllowed();
if (feeds[token] == address(0)) revert Errors.NoTokenPriceFeedAvailable();
In ChainlinkARBOracle::addTokenMaxDelay()
if (token == address(0)) revert Errors.ZeroAddressNotAllowed();
if (feeds[token] == address(0)) revert Errors.NoTokenPriceFeedAvailable();
In ChainlinkARBOracle::addTokenPriceFeed()
if (token == address(0)) revert Errors.ZeroAddressNotAllowed();
if (feed == address(0)) revert Errors.ZeroAddressNotAllowed();
In ChainlinkARBOracle::getMarketTokenInfo
if (address(marketToken) == address(0)) revert Errors.ZeroAddressNotAllowed();
if (address(indexToken) == address(0)) revert Errors.ZeroAddressNotAllowed();
if (address(longToken) == address(0)) revert Errors.ZeroAddressNotAllowed();
if (address(shortToken) == address(0)) revert Errors.ZeroAddressNotAllowed();
Here if we write the two conditions separately it increases the number of SSTORE operations, which can cost more gas.
Impact
Wastes gas
Tools Used
Manual Review
Recommendations
Combine the several checks into a single check
Prize pool breakdown
Total prize
35,000 USDC
nSLOC
2,28915 USDC / LOC
33,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.