Submission Details
Severity:
Slippage value needs to be verified
Summary
In calcMinMarketslippageAmt() in GMXManager do not check the slippage value entry and it has to be less than 1000.
Vulnerability Details
Inside of calcMinMarketSlippageAmt(), this sentence is running:
return depositValue
* SAFE_MULTIPLIER
/ _lpTokenValue
* (10000 - slippage) / 10000;
If the slippage is greater than 1000, they throw an unexpected error. "Arithmetic overflow/underflow".
Impact
Low, you can interrupt the process of deposit(), compound, rebalance(), etc. generating losses in the use of gas.
Tools Used
Manual code review
Recommendations
Add a condition for verification of the received value such as:
if(slippage > 10000 ) revert ErrorSlippage();
Prize pool breakdown
Total prize
35,000 USDC
nSLOC
2,28915
USDC / LOC
33,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.