Steadefi

Steadefi
DeFiHardhatFoundryOracle
35,000 USDC
View results
Submission Details
Severity: low
Invalid

Deposits are allowed above the MAX_PNL_FACTOR_FOR_DEPOSITS

Summary

GMX integration says that deposits must be below the MAX_PNL_FACTOR_FOR_DEPOSITS constant. In the protocol this is not checked anywhere during the deposit process

Vulnerability Details

Due the correct way in integrating the GMX v2 some constants are proportioned by the GMX team and help us to do not make bad calls, one of this is the: MAX_PNL_FACTOR_FOR_DEPOSITS that sets a max amt for deposits.

Impact

Unexpected behaviour, normally a revert from the GMX protocol.

Tools Used

Manual review

Recommendations

Add this check in the deposit process.

Updates

Lead Judging Commences

hans Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.