Submission Details
Severity:
Constructor parameters shadow other parameters
Summary
The GMXVault constructor declares the name and symbol, but they shadow the OZ ERC20 parameters.
Vulnerability Details
Declaring parameters that shadow existing ones is error-prone, as it can lead to developer confusion, potentially introduce bugs, and diminish code readability and maintainability.
https://github.com/Cyfrin/2023-10-SteadeFi/blob/main/contracts/strategy/gmx/GMXVault.sol#L71
Tools Used
Manual
Recommendations
Consider removing the parameters or storing them in GMXTypes.Store if every new deployment will have a unique name and symbol.
Prize pool breakdown
Total prize
35,000 USDC
nSLOC
2,28915 USDC / LOC
33,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.