Steadefi

Summary

Refer Details

Vulnerability Details

There Multiple instances where no checks present for execution fee. When i talked to sponsors they said that If Execution Fee is not enough then Tx will reverted by GMXv2, But problem here is that this whole system(strategy Contract) is like one lane(One Tx at a time), and gmxv2 handle transactions in 2 step process

If execution fee is wrong provided by user then it is rejected by the gmx then there would be more follow up function call to revert whole transaction and re-ride states to initial state.

Till that time this lane i.e strategy system will be blocked for other user.

So it will be great if Excution fee check present in initial state so that function call will revert in first step not to wait for responces form GMX

Impact

For some time contract will remain in blockage state, which can be prevented via reverting function eairlier.

Tools Used

Manual review

Recommendations

Execution fee check should be present in every function where call to GMXv2 present.