Steadefi

Steadefi
DeFiHardhatFoundryOracle
35,000 USDC
View results
Submission Details
Severity: medium
Valid

No slippage protection in `GMXEmergency:emergencyResume`

Summary

When resuming a vault, the slippage parameter is not set for addLiquidity.

Vulnerability Details

The emergencyResume function is called by the owner to resume the vault and re-add assets. The AddLiquidityParams set by the function does not include the minMarketTokenAmt. Since this parameter is used for slippage protection, the vault might receive much less tokens than expected.

Impact

The vault receives less LP tokens than it should.

Tools Used

Manual

Recommendations

Provide a minMarketTokenAmt parameter to the addLiquidity call when resuming the vault.

Updates

Lead Judging Commences

hans Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

Slippage protection on emergency Pause/Resume

Impact: High Likelihood: Low Because the whole lpToken balance is used during the emergency process, the impact is high. But the likelihood is LOW because of the dependence on the emergency.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.