Submission Details
Severity:
`minWithdrawTokenAmt` is not enforced for LP token withdrawals
Vulnerability Details
The minWithdrawTokenAmt is supposed to be a guarantee for the minimum amount of withdrawal token that would be received. But in implementation, the check is only made if the withdrawal token is either the long or short token.
function processWithdraw(
GMXTypes.Store storage self
) external {
........ more code
// @audit afterWithdrawChecks containing the check for `minWithdrawTokenAmt` is not made if the token is LP token
if (
self.withdrawCache.withdrawParams.token == address(self.tokenA) ||
self.withdrawCache.withdrawParams.token == address(self.tokenB)
) {
....... more code
GMXChecks.afterWithdrawChecks(self);
}
Impact
Users may be misguided and end up receiving lower amount of tokens than the input minWithdrawTokenAmt
Recommendations
Make a separate check minWithdrawTokenAmt check for LP tokens or mention it in the documentation
Prize pool breakdown
Total prize
35,000 USDC
nSLOC
2,28915 USDC / LOC
33,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.