Steadefi

Summary

The number of people that a single vault can accommodate has not been stated yet, but it might well go into the thousands, as more users are performing transactions, the more the possibility of delayed user Actions.

Vulnerability Details

Let's Explore How This Might Happen in a High Participation Vaults,

In a Normal transaction, you have a two step transaction, which takes approximately 20 seconds to 30 seconds due to external actors acting on them like the GMX Market Routers and the Keepers that have to be alerted

All the Numbers and times that the transactions take place could be increased in case of the transaction fails due to checks after or other factors, which would then make this process start all over again taking an equal amount of time too. Especially if they are many failed transactions

While all this is Going on The State of the vault is Not Set to Open, which Means other Users in the vault can not perform actions in the vaults

This Could not be an issue if there are just a few people in the vault, but in a high performing market with many people Participating, the probability of this happening is just as high.

Impact

The Impact of this Happening is That a DOS of users will occur as it will turn to a Game of the fastest finger to place a transaction or the fastest to get it approved by miners, I don't think users want to have that kind of experiences on the platform

Tools Used

Manual Analysis

Recommendations

My Recommendation is that the protocol, should, define the meaning of high performing vaults and know in the highest of activity in the vaults, which could lead to situation like this, and from that study the protocol team should know how much of users can a single vault accommodate without preventing issues like this, and maybe a mitigation will be to be create another vaults of the same asset for new users to participate in.