Submission Details
Severity:
Return values of approve() not checked
Summary
[M-3] Return values of approve() not checked
Not all IERC20 implementations revert() when there's a failure in approve(). The function signature has a boolean return value and they indicate errors that way instead. By not checking the return value, operations that should have marked as failed, may potentially go through without actually approving anything
file: /contracts/strategy/gmx/GMXWorker.sol
118 IERC20(sp.tokenIn).approve(address(self.swapRouter), sp.amountIn);
133 IERC20(sp.tokenIn).approve(address(self.swapRouter), sp.amountIn);
Prize pool breakdown
Total prize
35,000 USDC
nSLOC
2,28915 USDC / LOC
33,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.