Summary

The GMXVault.sol contract contains functions to update minimum slippage and minimum execution fees. However, these functions lack explicit checks to ensure that the provided values conform to the specified ranges.

Vulnerability Details

The functions updateMinSlippage and updateMinExecutionFee do not include checks to verify whether the input values for minSlippage and minExecutionFee adhere to the expected ranges of 1e4 and 1e18, respectively.
For example, mistakenly setting slippage or execution fees to zero could bypass important checks, for slippage potentially impacts the functioning of the contract and leads to no slippage protection. While it's primarily a concern of the owner's actions, there is a risk of unintended behavior if these values are not appropriately configured.

Impact

Setting slippage or execution fees to zero means the protocol will operate without any slippage protection. This could lead to undesirable consequences, such as higher trading risks, especially in volatile markets.

Tools Used

Manual code review.

Recommendations

Add checks within the updateMinSlippage and updateMinExecutionFee functions. These checks should ensure that the provided values are within acceptable bounds, preventing the inadvertent setting of these parameters to zero.

For example.