Summary

deposit() should be payable to work the native functionality

Vulnerability Details

In GMXDeposit.sol, deposit() is used for despositing the tokens. The functin has argument isNative which if true then this can be used to send the native tokens i.e eth however the function is not payable therefore the function wont work properly.

Impact

Without payable modifier on GMXDeposit.deposit() would break the native functionality.

Tools Used

MR

Recommendations

Make GMXDeposit.deposit() payable