Summary

Incorrect Equality

Vulnerability Details

This issue is present in several code lines as highlighed below:
GMXReader.debtRatio(GMXTypes.Store) (contracts/strategy/gmx/GMXReader.sol#220-224)
GMXReader.svTokenValue(GMXTypes.Store) (contracts/strategy/gmx/GMXReader.sol#27-32)
GMXReader.delta(GMXTypes.Store) (contracts/strategy/gmx/GMXReader.sol#194-214)
GMXReader.delta(GMXTypes.Store) (contracts/strategy/gmx/GMXReader.sol#194-214)
GMXReader.leverage(GMXTypes.Store) (contracts/strategy/gmx/GMXReader.sol#185-188)
GMXReader.valueToShares(GMXTypes.Store,uint256,uint256) (contracts/strategy/gmx/GMXReader.sol#48-56)

Impact

Use of strict equalities can be easily manipulated by an attacker.

Tools Used

Manual Review

Recommendations

Don't use strict equality to determine if an account has enough Ether or tokens.