First Flight #4: Boss Bridge

[L-01] Missing Events in L1BossBridge

Summary

The functions setSigner and sendToL1 are not emitting an event after making state changing operations.

Recommendation

Add events to these functions.

[L-02] DEPOSIT_LIMIT should be declared as constant

Summary

L1BossBridge does not define a method to update DEPOSIT_LIMIT after the deployment of the contract and for this reason its value will never change so the variable can be safely declared as a constant.

Recommendation

Mark the variable as constant.

[L-03] State variable token in L1Vault should be declare as immutable

Summary

During the deployment of the bridge, a single vault is created to handle one token for deposits.

Recomendation

Considering the vault does not provide a method to update the allowed token and it's value is initialized in the constructor of the vault then the variable should me marked as immutable.