First Flight #4: Boss Bridge

Summary

This issue pertains to the absence of the constant keyword in the declaration of the variable DEPOSIT_LIMIT within the file L1BossBridge.sol.

Vulnerability Details

During a manual review and utilizing tools such as 4nalizer and Slither, it was identified that the variable DEPOSIT_LIMIT in the file L1BossBridge.sol lacks the constant keyword.

Here's the relevant code snippet:

Impact

The impact of this issue is considered low. Adding the constant keyword to the variable DEPOSIT_LIMIT brings advantages, such as improved gas efficiency, preventing unnecessary state changes, and enhancing code clarity.

Tools Used

• Manual Review

• 4nalizer

• Slither

Recommendations

To address this issue, it is recommended to add the constant keyword to the declaration of the variable DEPOSIT_LIMIT. Utilizing the constant keyword for values that do not change during the contract's execution provides gas efficiency benefits and ensures that the variable remains unchanged throughout the contract's lifecycle.