First Flight #4: Boss Bridge

Summary

The function setSigner changes the status of an address as a signer or not, but does not emit an event to notify the users and the watchers.

Vulnerability Details

This could make the contract less transparent and observable, and reduce the trust and confidence of the users and the developers.
The function should emit an event to record the state changes that it causes, and to make the contract more auditable and verifiable.

Impact

The impact of this issue is that the function setSigner could make the contract less auditable and verifiable, as it does not provide any evidence of the state changes that it causes. This could make it harder for the users and the developers to track the history and the current state of the signers, and to detect any errors or malicious actions that might occur. Therefore, it is important to emit events in setter functions to make the contract more reliable and secure.

Tools Used

• slither

Recommendations

You should emit events in setter functions to make the contract more transparent and observable.