First Flight #4: Boss Bridge

Summary

The TokenFactory contract uses a mapping from token symbols to addresses (s_tokenToAddress). However, it does not prevent the reuse of symbols. If the same symbol is used more than once, the new address will overwrite the previous one in the mapping. This could lead to confusion or misrepresentation of tokens, especially if symbols are expected to uniquely identify a token.

Vulnerability Details

If the owner of TokenFactory deploy a new contract using an already used symbol, accidentialy or not, the value will be overwritten and the previous mapping will be lost.

Impact

This can lead to the loss of mappings.

Tools Used

Manual analysis

Recommendations

Add checks to revert if a symbol is already used before deploying the new contract in deployToken function.