Submission Details
Severity:
success of approve is not listened to in L1Vault::approveTo
Summary
In L1Vault, the success of approve is not listened to in theapproveTo function. If approve fails for some reason, the constructor of L1BossBridge will not revert.
Vulnerability Details
The is a chance that L1BossBridge is deployed buy the approve function in L1Vault fails. This would be bad since L1BossBridge would be deployed without having any allowance.
Impact
The impact is quite low since all funds would be secure. On the other hands the users might have a non working service for that token.
Tools Used
Slither and manual review.
Recommendations
Following best practices of the approve function would fix the issue.
function approveTo(address target, uint256 amount) external onlyOwner {
bool success = token.approve(target, amount);
require(success, "Approval failed");
}
Rewards breakdown
nSLOC
99This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.