Submission Details
Severity:
Everyone starts as a NICE person, defeating the purpose of the presents
Summary
Mapping of both s_theListCheckedOnce & s_theListCheckedTwice defaults to 0, making them already a nice person and able to claim the presents defeating the purpose of the checks.
Vulnerability Details
function test_anyoneCanClaim() public {
vm.startPrank(attacker);
vm.warp(santasList.CHRISTMAS_2023_BLOCK_TIME() + 1);
santasList.collectPresent();
vm.stopPrank();
}
Impact
Everyone can claim NFT Presents including people not in Santa's list or if Santa forgets to check an individual.
Tools Used
Foundry
Recommendations
Start users out with an UNCHECKED status
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
default status is nice
In Solidity the first element of an enum is the default value. In Santa's List, the means each person is mapped by default to 'NICE'.
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.