First Flight #5: Santa's List
First Flight #5
Beginner FriendlyFoundry
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Unused constant `PURCHASED_PRESENT_COST`

bobadj

Summary

Unused constant PURCHASED_PRESENT_COST

Vulnerability Details

N/A

Impact

PURCHASED_PRESENT_COST is unnecessary as it is not used anywhere

Tools Used

Manually

Recommendations

  1. Remove PURCHASED_PRESENT_COST or

  2. Refactor contracts to use PURCHASED_PRESENT_COST

    1. Refactor mint and burn functions in SantaToken.sol to accept uint256 as the second argument

    2. Refactor collectPresent and _mintAndIncrement in SantasList.sol and pass PURCHASED_PRESENT_COST while calling mint or burn on SantaToken.sol

SantaToken.sol

...
-21 function mint(address to) external {
+21 function mint(address to, uint256 amount) external {
22 if (msg.sender != i_santasList) {
23 revert SantaToken__NotSantasList();
24 }
-25 _mint(to, 1e18);
+25 _mint(to, amount);
26 }
...
-28 function burn(address from) external {
+28 function burn(address from, uint256 amount) external {
29 if (msg.sender != i_santasList) {
30 revert SantaToken__NotSantasList();
31 }
-32 _burn(from, 1e18);
+32 _burn(from, amount);
33 }
...

SantasList.sol

...
147 function collectPresent() external {
...
-162 i_santaToken.mint(msg.sender);
+162 i_santaToken.mint(msg.sender, PURCHASED_PRESENT_COST);
163 return;
164 }
165 revert SantasList__NotNice();
166 }
...
172 function buyPresent(address presentReceiver) external {
-173 i_santaToken.burn(presentReceiver);
+173 i_santaToken.burn(presentReceiver, PURCHASED_PRESENT_COST);
174 _mintAndIncrement();
175 }
...
Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.