Present Purchase Cost is not Used
Summary
Purchasing a present only costs 1e18 tokens, not 2e18 as intended.
Vulnerability Details
In SantasList.sol PURCHASED_PRESENT_COST = 2e18 Is declared but never used
AND
SantaToken.sol burn defaults to only 1e18
Impact
Twice as many purchased presents will ultimately exist.
A market for the tokens is less likely to develop as people will simply spend the token directly.
Tools Used
N/A
Recommendations
PURCHASED_PRESENT_COST should be passed as a parameter to the SantaToken.sol burn function
Lead Judging Commences
Price is not enforced in buyPresent
This line indicates that the intended cost of presents for naughty people should be 2e18: https://github.com/Cyfrin/2023-11-Santas-List/blob/6627a6387adab89ae2ba2e82b38296723261c08a/src/SantasList.sol#L87 PURCHASE_PRESENT_COST should be implemented to enforce the cost of presents.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.