Submission Details
Severity:
Cannot change status in checkTwice
Summary
In the natspec of the contract we have:
A function that changes an address to a new Status of NICE, EXTRA_NICE, NAUGHTY, or UNKNOWN on the new s_theListCheckedTwice list only if someone has already been marked on the s_theListCheckedOnce.
But the code checks if the first status is the same as the second status we input.
Resulting that we can NOT change the status as intended, only to make it the same as in the first check.
Vulnerability Details
Santa will not be able to change the status to a NEW status as intended in the protocol.
Impact
Tools Used
Manual review
Recommendations
Implement new value in enum STATUS:
enum Status {
UNCHECKED
NICE,
EXTRA_NICE,
NAUGHTY,
NOT_CHECKED_TWICE
}
Change code to
- if (s_theListCheckedOnce[person] != status) {
+ if (s_theListCheckedOnce[person] != Status.UNCHECKED) {
revert SantasList__SecondCheckDoesntMatchFirst();
}
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.