Function checkList lacks onlySanta modifier
Summary
Function checkList is available for only Santa by design. But lack of onlySanta modifier opens access to the function for everyone.
Vulnerability Details
https://github.com/Cyfrin/2023-11-Santas-List/blob/main/src/SantasList.sol#L121
Impact
User can set up his first Status on his own. However, the function checkTwice is available to call only by Santa,
so first Status alone won't help user to fraud function collectPresent.
User can still cause denial by front-running Santa's checkTwice with checkList call.
Tools Used
Manual
Recommended Mitigation
Add onlySanta modifier to checkList function.
Lead Judging Commences
Access Control on checkList()
Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.