Submission Details
Severity:
`SantasList::checkList` is missing modifier
Summary
The function checkList is missing modifier onlySanta. This is required because this function can only by called by santa. We can see that in checkTwice function.
Impact
Anyone can call checkList
Tools Used
Manual Review, Foundry
Proof of Concept
Changed the test file to this:
function testCheckList() public {
- vm.prank(santa);
+ vm.prank(user);
santasList.checkList(user, SantasList.Status.NICE);
assertEq(uint256(santasList.getNaughtyOrNiceOnce(user)), uint256(SantasList.Status.NICE));
}
Test passes:
[PASS] testCheckList() (gas: 16069)
Recommendations
Add onlySanta modifier
function checkList(address person, Status status) external onlySanta {
s_theListCheckedOnce[person] = status;
emit CheckedOnce(person, status);
}
Updates
Lead Judging Commences
inallhonesty almost 2 years ago
Submission Judgement Published Assigned finding tags:
Access Control on checkList()
Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.