Submission Details
Severity:
buyPresent function does not work as intended
Summary
buyPresent function burns tokens that belong to presentReceiver
Vulnerability Details
A malicious user can call the function and will burn the victim's tokens.
i_santaToken.burn(presentReceiver);
Than he will receive the NFT.
Impact
presentReceiver will get his tokens burned but will not receive the NFT
Tools Used
Manual review
Recommendations
Change function to:
function buyPresent(address presentReceiver) external {
- i_santaToken.burn(presentReceiver);
+ i_santaToken.burn(msg.sender);
_mintAndIncrement();
+ _safeTransfer(msg.sender,presentReceiver,s_tokenCounter-1);
}
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
buyPresent should use msg.sender
Current implementation allows a malicious actor to burn someone else's tokens as the burn function doesn't actually check for approvals.
buyPresent should send to presentReceiver
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.